Conversation
also a bunch of stuff left to do Seems to build at least so there's that
…ject files are not dropped by minimize
Test Results 56 files ±0 56 suites ±0 3m 26s ⏱️ + 1m 35s Results for commit 658b69a. ± Comparison against base commit fe50bd8. This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current build is not setup properly, leading to several issues, for example jar file contents (shadowed dependencies are being published in the jar), empty modules being published or the unabilitiy to upgrade to gradle 9 due to deprecated gradle features being used for a long time.
Modification
Rework and cleanup the entire gradle build, upgrade to gradle 9.1.0, activate configuration cache. Fixed task execution, build now actually builds everything (to be more precise: assemble builds everything, build is assemble + all tests/checks).
Result
Overall better build performance and no more deprecated features used.
Other context
Resolves #1611 (based upon the linked pr, with more cleanups and fixed applied)