Skip to content

fix: remove invalid service annotations#1728

Merged
derklaro merged 1 commit intonightlyfrom
invalid-service-annotations
Aug 24, 2025
Merged

fix: remove invalid service annotations#1728
derklaro merged 1 commit intonightlyfrom
invalid-service-annotations

Conversation

@derklaro
Copy link
Member

Motivation

There were some invalid service annotations left in the source, leading to functionality not working.

Modification

Remove these invalid service annotations.

Result

Everything works as expected again.

@derklaro derklaro requested a review from 0utplay August 24, 2025 08:13
@derklaro derklaro self-assigned this Aug 24, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules labels Aug 24, 2025
@derklaro derklaro added this to the 4.0.0-RC15 milestone Aug 24, 2025
@github-actions
Copy link

github-actions bot commented Aug 24, 2025

Test Results

 56 files  ±0   56 suites  ±0   2m 20s ⏱️ +2s
570 tests ±0  570 ✅ ±0  0 💤 ±0  0 ❌ ±0 
935 runs  ±0  935 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 77defd9. ± Comparison against base commit 146fe72.

This pull request removes 33 and adds 33 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-08-22
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 17:59:18.938866767
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 17:59:18.938970371Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 17:59:18.938991551Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 17:59:18.939015105+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 17:59:18.939031256-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-08-22T17:59:18.939161670
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-08-22T17:59:18.939293898Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-08-22T17:59:18.934691295Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","this":"is","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-08-24
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 09:18:43.965302205
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 09:18:43.965447497Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 09:18:43.965470179Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 09:18:43.965496618+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 09:18:43.965520272-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-08-24T09:18:43.965649254
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-08-24T09:18:43.965782472Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-08-24T09:18:43.952176800Z
…

♻️ This comment has been updated with latest results.

@derklaro derklaro merged commit 828961d into nightly Aug 24, 2025
6 of 8 checks passed
@derklaro derklaro deleted the invalid-service-annotations branch August 24, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: module An issue/pull request releated to one of the internal modules t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants