chore: reduce heap usage when doing chunked data transfer#1702
Merged
chore: reduce heap usage when doing chunked data transfer#1702
Conversation
derklaro
added
v: 4.X
Test Results 56 files ±0 56 suites ±0 3m 7s ⏱️ +38s Results for commit 854b437. ± Comparison against base commit dcce1a8. This pull request removes 29 and adds 29 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
driver/api/src/main/java/eu/cloudnetservice/driver/network/buffer/DataBuf.java
Outdated
Show resolved
Hide resolved
driver/api/src/main/java/eu/cloudnetservice/driver/network/buffer/DataBuf.java
Outdated
Show resolved
Hide resolved
0utplay
previously approved these changes
Jul 22, 2025
0utplay
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, chunked data transfers are copying the data via the heap into the target netty buffer (and vice-versa). This is very inefficient as this means that a native memory segment is copied to the heap and then back into a native memory segment.
Modification
Use nio Channels in combination with ByteBuffers to directly read/write the content being transferred to/from the netty buffer, completely removing the need for (almost) any heap allocations.
Result
Reduced heap usage when doing a chunked data transfers.