Skip to content

fix: complete pending queries when channel is closed#1694

Merged
derklaro merged 1 commit intonightlyfrom
pending-queries-close
Jul 20, 2025
Merged

fix: complete pending queries when channel is closed#1694
derklaro merged 1 commit intonightlyfrom
pending-queries-close

Conversation

@derklaro
Copy link
Member

Motivation

Currently, pending queries are not completed when the connection to a network component is lost, making them stall until the query timeout is reached.

Modification

Complete pending queries with a ClosedChannelException when a channel gets closed.

Result

No more stalling queries due to network components disconnecting.

@derklaro derklaro added this to the 4.0.0-RC14 milestone Jul 19, 2025
@derklaro derklaro requested a review from 0utplay July 19, 2025 18:17
@derklaro derklaro self-assigned this Jul 19, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release in: driver An issue/pull request releated to the driver module code t: fix A pull request introducing a fix for a bug. labels Jul 19, 2025
@github-actions
Copy link

Test Results

 56 files  ±0   56 suites  ±0   2m 4s ⏱️ -42s
570 tests ±0  570 ✅ ±0  0 💤 ±0  0 ❌ ±0 
935 runs  ±0  935 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 8ee0e4f. ± Comparison against base commit a7046d1.

This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","hello":"world","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-07-17
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 08:28:51.343299863
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 08:28:51.343409378Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 08:28:51.343429646Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 08:28:51.343450194+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 08:28:51.343465763-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-07-17T08:28:51.343592149
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-07-17T08:28:51.343720339Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-07-17T08:28:51.337132534Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-07-19
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 18:19:38.468234136
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 18:19:38.468340686Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 18:19:38.468361786Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 18:19:38.468384429+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 18:19:38.468401501-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-07-19T18:19:38.468527969
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-07-19T18:19:38.468660769Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-07-19T18:19:38.461440467Z
…

@derklaro derklaro merged commit 31417a6 into nightly Jul 20, 2025
6 checks passed
@derklaro derklaro deleted the pending-queries-close branch July 20, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: driver An issue/pull request releated to the driver module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants