fix: override pull(Async) in RemoteTemplateStorage#1692
Merged
Conversation
Test Results 56 files ±0 56 suites ±0 2m 46s ⏱️ ±0s Results for commit 9923731. ± Comparison against base commit a7046d1. This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both. |
0utplay
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RemoteTemplateStorage does currently not override
pullandpullAsyncleading to the methods being executed on the node. This leads to an issue where the template is not pulled into the a relative path to the current wrapper directory, but relative to the node directory.Modification
Override
pullandpullAsyncto let them use the chunked data transfer infrastructure and extract the zipped template into the (possible relative to the service directory) path passed to the respectivepullmethod.Result
RemoteTemplateStorage has a correct implementation of
pullandpullAsync.Other context
Fixes #1303