chore: fetch all paper downloads from api#1684
Merged
Conversation
derklaro
added
v: 4.X
0utplay
approved these changes
Jul 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently the download urls of old paper versions are hardcoded in the
versions.jsonfile, which shouldn't be done. As the paper api v3 update announcement states:[...] and we advise against doing so, as the format may change.Modification
Always request the download url for a version from the paper downloads api instead of hardcoding them.
Result
Download urls of old paper versions are resolved from the paper api instead of being hardcoded, as recommended in the update announcement.