feat: split sign text color and glowing setting#1670
Merged
Conversation
derklaro
added
v: 4.X
0utplay
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Since minecraft 1.14 the text color of a sign can be changed and since 1.17 the text of a sign can glow. We currently only support both options in one setting, which should be split up into two.
Modification
Add a setting to set the text color of a sign and one to set the glowing state of a sign. Also fixes the sign handling on minestom, as it was still using the pre-1.20 sign nbt format.
Result
The text color of a sign can be configured separately from the fact if the sign text is glowing.