Merged
Conversation
Test Results 56 files ±0 56 suites ±0 2m 14s ⏱️ - 1m 1s Results for commit c030f29. ± Comparison against base commit 1f00abb. This pull request removes 31 and adds 31 tests. Note that renamed tests count towards both. |
0utplay
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current sign layout ticking process is based on the assumption that there won't be any race conditions. However, there is a slim chance that a race happens which will then cause all layouts of a holder to freeze until a server restart or config reload.
Modification
Base the sign ticking process and layout retrieval entirely on the last tick when the sign was updated. This removes the need for different places to lock/unlock sign layout ticking and therefore prevents races between the sign ticking thread and the main server thread. This also applies to the map that tracks the layouts that need to be updated as a result of the current tick.
Result
Sign layout ticking is resistent against race conditions and uses the server tick count as the single point of truth when retrieving the applicable sign layout.