Skip to content

feat: enhance sign module compat with new minecraft versions#1665

Merged
derklaro merged 1 commit intonightlyfrom
sign-module-compat
Jun 24, 2025
Merged

feat: enhance sign module compat with new minecraft versions#1665
derklaro merged 1 commit intonightlyfrom
sign-module-compat

Conversation

@derklaro
Copy link
Member

Motivation

New minecraft versions introduced new sign types and options that aren't yet supported in the sign module. These are:

  1. hanging signs (facing wasn't determined correctly yet for all sign types)
    2, sign text from both sides of a sign (relevant for hanging signs)

Modification

  1. Replace usage of reflexion with bare method handles. This allows for better performance which is relevant as all methods in BukkitCompatibility are called on the main server thread.
  2. Support retrieval of sign faces for all types of signs.
  3. Support the new SignSide bukkit api and apply text (and other options) to both sides of a sign instead of just the front.

Result

Sign changes in recent minecraft/bukkit versions are now supported by the signs module.

@derklaro derklaro added this to the 4.0.0-RC13 milestone Jun 21, 2025
@derklaro derklaro requested a review from 0utplay June 21, 2025 15:58
@derklaro derklaro self-assigned this Jun 21, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release t: improvement The pull request improves existing code in: module An issue/pull request releated to one of the internal modules labels Jun 21, 2025
@github-actions
Copy link

Test Results

 56 files  ±0   56 suites  ±0   2m 27s ⏱️ -18s
566 tests ±0  566 ✅ ±0  0 💤 ±0  0 ❌ ±0 
931 runs  ±0  931 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2792313. ± Comparison against base commit 159486f.

@derklaro derklaro merged commit 52081f8 into nightly Jun 24, 2025
6 checks passed
@derklaro derklaro deleted the sign-module-compat branch June 24, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: module An issue/pull request releated to one of the internal modules t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants