feat: allow node host override in docker module#1659
Merged
Conversation
derklaro
added
v: 4.X
0utplay
approved these changes
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The ip/port that can be used from inside a docker network to connect to a node listener on the host system might be different that any configured listener on the node (e.g.
host.docker.internalin some cases). There is currently no way to connect to a node listener outside the docker network (except for custom modules/server implementations).Modification
Add the possibility to override the node host (globally and task-specific) to allow specifying a different host and port to connect to from inside a docker network.
Result
Services can connect to a node listener bound outside of a docker network.