fix: logging configuration properties not working from launcher.cnl#1647
Merged
derklaro merged 4 commits intoCloudNetService:nightlyfrom Jun 3, 2025
ttugrul:logging-var-fix
Merged
fix: logging configuration properties not working from launcher.cnl#1647derklaro merged 4 commits intoCloudNetService:nightlyfrom ttugrul:logging-var-fix
derklaro merged 4 commits intoCloudNetService:nightlyfrom
ttugrul:logging-var-fix
Conversation
Problem Settings for logging in launcher.cnl for logging were ignored Cause Logback was using cached variables instead of reading the actual system properties set by the launcher. Fix Changed logback XML files to read system properties directly
Fix logging configuration properties not working from launcher.cnl Problem Settings for logging in launcher.cnl for logging were ignored Cause Logback was using cached variables instead of reading the actual system properties set by the launcher. Fix Changed logback XML files to read system properties directly
Member
|
I wonder if it would be better to move the variable subsitutation into the variable values, so that they are defined at the top of the configuration. I think the same result can be achived using something like: <variable name="cloudnet.log.level" value="${cloudnet.log.level:-DEBUG}"/> |
0utplay
approved these changes
Jun 3, 2025
Member
|
@ttugrul thanks! |
GiantTreeLP
pushed a commit
to GiantTreeLP/CloudNet
that referenced
this pull request
Jun 7, 2025
…oudNetService#1647) Motivation Logging properties set in launcher.cnl (like var cloudnet.log.level OFF) were being ignored. Modification Changed logback XML files to read system properties directly instead of using cached variables. Result Logging configuration from launcher.cnl now works correctly. Users can set custom log levels and paths. --------- Co-authored-by: Pasqual Koschmieder <git@derklaro.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Logging properties set in launcher.cnl (like var cloudnet.log.level OFF) were being ignored.
Modification
Changed logback XML files to read system properties directly instead of using cached variables:
${cloudnet.log.level} → ${cloudnet.log.level:-DEBUG}
${cloudnet.log.path} → ${cloudnet.log.path:-local/logs}
Result
Logging configuration from launcher.cnl now works correctly. Users can set custom log levels and paths.
Other context
Fixes timing issue where logback initialized before system properties were available.