feat: make command confirmations skippable using extra flag#1645
Merged
feat: make command confirmations skippable using extra flag#1645
Conversation
Test Results 50 files ±0 50 suites ±0 1m 33s ⏱️ +8s Results for commit 145a157. ± Comparison against base commit e012273. This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
In #1579 it was requested to make command confirmations (like needed for
exit) skippable using a flag.Modification
Added a new
@SkipConfirmationannotation which allows to specify a flag name which can be used to skip the confirmation of a command. This PR also directly includes this annotation for the exit command so that it can be skipped using--skipResult
Commands that need to be confirmed can be skipped if requested.
Other context
Resolves #1579