Skip to content

feat: make command confirmations skippable using extra flag#1645

Merged
0utplay merged 9 commits intonightlyfrom
feat/skippable-command-confirm
Jun 7, 2025
Merged

feat: make command confirmations skippable using extra flag#1645
0utplay merged 9 commits intonightlyfrom
feat/skippable-command-confirm

Conversation

@0utplay
Copy link
Member

@0utplay 0utplay commented May 31, 2025

Motivation

In #1579 it was requested to make command confirmations (like needed for exit) skippable using a flag.

Modification

Added a new @SkipConfirmation annotation which allows to specify a flag name which can be used to skip the confirmation of a command. This PR also directly includes this annotation for the exit command so that it can be skipped using --skip

Result

Commands that need to be confirmed can be skipped if requested.

Other context

Resolves #1579

@0utplay 0utplay added this to the 4.0.0-RC13 milestone May 31, 2025
@0utplay 0utplay requested a review from derklaro May 31, 2025 14:18
@0utplay 0utplay self-assigned this May 31, 2025
@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code labels May 31, 2025
@github-actions
Copy link

github-actions bot commented May 31, 2025

Test Results

 50 files  ±0   50 suites  ±0   1m 33s ⏱️ +8s
446 tests ±0  446 ✅ ±0  0 💤 ±0  0 ❌ ±0 
777 runs  ±0  777 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 145a157. ± Comparison against base commit e012273.

This pull request removes 34 and adds 34 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","hello":"world","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-05-26
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 16:50:58.023513119
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 16:50:58.028691896Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 16:50:58.028716863Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 16:50:58.028743192+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 16:50:58.028761697-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-05-26T16:50:58.028893203
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-05-26T16:50:58.029037643Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-05-26T16:50:58.020314085Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-06-07
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 14:00:42.665718234
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 14:00:42.665837978Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 14:00:42.665861883Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 14:00:42.665887370+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 14:00:42.666092274-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-06-07T14:00:42.666247204
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-06-07T14:00:42.666382707Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-06-07T14:00:42.662170428Z
…

♻️ This comment has been updated with latest results.

@0utplay 0utplay merged commit adbe832 into nightly Jun 7, 2025
5 checks passed
@0utplay 0utplay deleted the feat/skippable-command-confirm branch June 7, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: node An issue/pull request releated to the node module code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add force argument to /exit

2 participants