feat: allow subnets in node ip allowlist#1644
Merged
Conversation
Test Results 51 files +1 51 suites +1 1m 29s ⏱️ +4s Results for commit f6cfe32. ± Comparison against base commit e012273. This pull request removes 34 and adds 40 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
0utplay
approved these changes
Jun 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current node ip allowlist is only able to handle static ip addresses, not subnets. This causes issues with subnet usage, for example, when running services in docker containers using a custom network.
Modification
Add support for subnets in the node ip allowlist. The allowlist accepts static ips or subnets, depending on the fact if the allowlist entry contains a
/to delimit the ip from the subnet prefix length.Result
The ip allowlist can now handle subnets alongside static ip addresses.