Skip to content

feat: allow subnets in node ip allowlist#1644

Merged
derklaro merged 3 commits intonightlyfrom
node-allowlist-subnets
Jun 9, 2025
Merged

feat: allow subnets in node ip allowlist#1644
derklaro merged 3 commits intonightlyfrom
node-allowlist-subnets

Conversation

@derklaro
Copy link
Member

Motivation

The current node ip allowlist is only able to handle static ip addresses, not subnets. This causes issues with subnet usage, for example, when running services in docker containers using a custom network.

Modification

Add support for subnets in the node ip allowlist. The allowlist accepts static ips or subnets, depending on the fact if the allowlist entry contains a / to delimit the ip from the subnet prefix length.

Result

The ip allowlist can now handle subnets alongside static ip addresses.

@derklaro derklaro added this to the 4.0.0-RC13 milestone May 30, 2025
@derklaro derklaro requested a review from 0utplay May 30, 2025 08:50
@derklaro derklaro self-assigned this May 30, 2025
@derklaro derklaro added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: improvement The pull request improves existing code labels May 30, 2025
@github-actions
Copy link

github-actions bot commented May 30, 2025

Test Results

 51 files  +1   51 suites  +1   1m 29s ⏱️ +4s
452 tests +6  452 ✅ +6  0 💤 ±0  0 ❌ ±0 
783 runs  +6  783 ✅ +6  0 💤 ±0  0 ❌ ±0 

Results for commit f6cfe32. ± Comparison against base commit e012273.

This pull request removes 34 and adds 40 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","hello":"world","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-05-26
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 16:50:58.023513119
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 16:50:58.028691896Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 16:50:58.028716863Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 16:50:58.028743192+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 16:50:58.028761697-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-05-26T16:50:58.028893203
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-05-26T16:50:58.029037643Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-05-26T16:50:58.020314085Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2025-06-07
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 14:00:42.665718234
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 14:00:42.665837978Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 14:00:42.665861883Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 14:00:42.665887370+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 14:00:42.666092274-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2025-06-07T14:00:42.666247204
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2025-06-07T14:00:42.666382707Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2025-06-07T14:00:42.662170428Z
…

♻️ This comment has been updated with latest results.

@derklaro derklaro merged commit 1b3796b into nightly Jun 9, 2025
5 checks passed
@derklaro derklaro deleted the node-allowlist-subnets branch June 9, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: node An issue/pull request releated to the node module code t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants