fix: service copy without default template#1558
Merged
Conversation
Test Results 48 files ±0 48 suites ±0 1m 40s ⏱️ -1s Results for commit 119bb58. ± Comparison against base commit 71fa7ca. This pull request removes 38 and adds 38 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Dec 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When copying a service without providing a template we try to fallback to the "/default" template. But our fallback logic is not working correctly and causing an NPE.
Modification
We now only accept a single service when copying. If no default template exists and no template is provided we respond with an message indicating the missing template.
Result
The
service <Service> copyCommand is working again.Other context
Fixes #1550