fix: NPE with not spawned npcs due to missing inventories#1554
Merged
fix: NPE with not spawned npcs due to missing inventories#1554
Conversation
0utplay
added
v: 4.X
derklaro
approved these changes
Dec 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When an NPC is spawned, the inventory of the NPC is created too. But we only spawn NPCs if they are located in a loaded chunk, therefore we have them tracked, but they do not have a corresponding inventory yet. This leads to an NPE when interacting with an already spawned NPC.
Modification
Turned around our equals check for inventories when processing clicks on items. This ensures that no NPE can occur.
Result
Clicking on NPC selector items is working properly again.