fix: add the default task setup back to the initial setup#1534
Merged
fix: add the default task setup back to the initial setup#1534
Conversation
Test Results 48 files ±0 48 suites ±0 1m 56s ⏱️ +4s Results for commit cdcc921. ± Comparison against base commit 93cdaf4. This pull request removes 37 and adds 37 tests. Note that renamed tests count towards both. |
derklaro
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
After the removal of CloudPerms the initial setup did not contain the default task setup for
LobbyandProxyanymore because it only relied on the fact that the task provider was initialized before the setup was started. The removal of CloudPerms also removed that early init and thus the setup was not complete anymore.Modification
Added the task provider as parameter to the setup step of the node. Aerogel is forced to init the provider first and therefore the setup is registered before the actual start of the setup.
Result
The default task setup is back.