Skip to content

feat: allow customizing the npc head rotation#1497

Merged
derklaro merged 7 commits intonightlyfrom
npc-rotation-improvement
Sep 15, 2024
Merged

feat: allow customizing the npc head rotation#1497
derklaro merged 7 commits intonightlyfrom
npc-rotation-improvement

Conversation

@0utplay
Copy link
Member

@0utplay 0utplay commented Sep 1, 2024

Motivation

Currently npcs (if lookAtPlayer is disabled) always face towards 0:0. Some users requested to be able to change the rotation of the npc.

Modification

The rotation packets are now send according to the position and a new rotate command was added which makes simple rotation changes possible.

Result

NPCs can have custom rotations

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: improvement The pull request improves existing code in: module An issue/pull request releated to one of the internal modules labels Sep 1, 2024
@0utplay 0utplay added this to the 4.0.0-RC11 milestone Sep 1, 2024
@0utplay 0utplay requested a review from derklaro September 1, 2024 08:43
@0utplay 0utplay self-assigned this Sep 1, 2024
@0utplay
Copy link
Member Author

0utplay commented Sep 1, 2024

FYI: this PR requires a new (currently not published) npc-lib version. Until the version beta9 is published, this PR is blocked.

@derklaro
Copy link
Member

derklaro commented Sep 2, 2024

@0utplay beta9 is available now, the version bump can be in this PR as well imo

@0utplay 0utplay marked this pull request as ready for review September 3, 2024 15:41
@github-actions
Copy link

github-actions bot commented Sep 3, 2024

Test Results

 48 files  ±0   48 suites  ±0   2m 3s ⏱️ -9s
420 tests ±0  420 ✅ ±0  0 💤 ±0  0 ❌ ±0 
751 runs  ±0  751 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9c7acf9. ± Comparison against base commit c37bd68.

This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","this":"is","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-08-18
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 16:05:05.295014907
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 16:05:05.295073568Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 16:05:05.295095379Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 16:05:05.295103965+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 16:05:05.295121077-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-08-18T16:05:05.295157787
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-08-18T16:05:05.295210827Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-08-18T16:05:05.294784352Z
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-09-09
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 11:16:58.666572570
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 11:16:58.666629948Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 11:16:58.666652390Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 11:16:58.666662418+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 11:16:58.666681073-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-09-09T11:16:58.666730967
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-09-09T11:16:58.666788284Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-09-09T11:16:58.664371750Z
…

♻️ This comment has been updated with latest results.

Copy link
Member

@derklaro derklaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just a bit of discussion about the messages

@0utplay 0utplay requested a review from derklaro September 9, 2024 11:14
@derklaro derklaro enabled auto-merge (squash) September 15, 2024 14:52
@derklaro derklaro changed the title feat: allow custom npc rotation feat: allow customizing the npc head rotation Sep 15, 2024
@derklaro derklaro disabled auto-merge September 15, 2024 14:52
@derklaro derklaro merged commit df11f99 into nightly Sep 15, 2024
@derklaro derklaro deleted the npc-rotation-improvement branch September 15, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: module An issue/pull request releated to one of the internal modules t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants