feat: allow customizing the npc head rotation#1497
Merged
Conversation
Member
Author
|
FYI: this PR requires a new (currently not published) npc-lib version. Until the version |
Member
|
@0utplay beta9 is available now, the version bump can be in this PR as well imo |
Test Results 48 files ±0 48 suites ±0 2m 3s ⏱️ -9s Results for commit 9c7acf9. ± Comparison against base commit c37bd68. This pull request removes 36 and adds 36 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
derklaro
reviewed
Sep 9, 2024
Member
derklaro
left a comment
There was a problem hiding this comment.
Code looks good, just a bit of discussion about the messages
...es/npcs/src/main/java/eu/cloudnetservice/modules/npc/platform/bukkit/command/NPCCommand.java
Outdated
Show resolved
Hide resolved
...es/npcs/src/main/java/eu/cloudnetservice/modules/npc/platform/bukkit/command/NPCCommand.java
Outdated
Show resolved
Hide resolved
...es/npcs/src/main/java/eu/cloudnetservice/modules/npc/platform/bukkit/command/NPCCommand.java
Outdated
Show resolved
Hide resolved
...es/npcs/src/main/java/eu/cloudnetservice/modules/npc/platform/bukkit/command/NPCCommand.java
Outdated
Show resolved
Hide resolved
...es/npcs/src/main/java/eu/cloudnetservice/modules/npc/platform/bukkit/command/NPCCommand.java
Outdated
Show resolved
Hide resolved
derklaro
approved these changes
Sep 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently npcs (if lookAtPlayer is disabled) always face towards 0:0. Some users requested to be able to change the rotation of the npc.
Modification
The rotation packets are now send according to the position and a new rotate command was added which makes simple rotation changes possible.
Result
NPCs can have custom rotations