feat: toggle for remote inclusion caches#1413
Merged
Conversation
derklaro
reviewed
May 26, 2024
node/src/main/java/eu/cloudnetservice/node/service/defaults/AbstractService.java
Outdated
Show resolved
Hide resolved
Test Results 48 files ±0 48 suites ±0 2m 6s ⏱️ -9s Results for commit 2e67937. ± Comparison against base commit 18530b6. This pull request removes 33 and adds 33 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
sieeeht gut aus, wird uns freuen |
|
passt oder |
derklaro
previously approved these changes
Jun 2, 2024
Member
derklaro
left a comment
There was a problem hiding this comment.
Look good in general, just one thought: would it be better to implement equals/hashCode for inclusions specifically? I'm wondering if cacheFiles anwhere contributes anything, that would make it a requirement to include in these methods...
node/src/main/java/eu/cloudnetservice/node/service/defaults/AbstractService.java
Outdated
Show resolved
Hide resolved
derklaro
requested changes
Aug 9, 2024
driver/src/main/java/eu/cloudnetservice/driver/service/ServiceRemoteInclusion.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/eu/cloudnetservice/driver/service/ServiceRemoteInclusion.java
Show resolved
Hide resolved
driver/src/main/java/eu/cloudnetservice/driver/service/ServiceRemoteInclusion.java
Outdated
Show resolved
Hide resolved
driver/src/main/java/eu/cloudnetservice/driver/service/ServiceRemoteInclusion.java
Show resolved
Hide resolved
derklaro
approved these changes
Aug 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some users use remote inclusions to always download latest files of certain plugins. The automatic caches makes that a bit hard.
Modification
Added a new
cacheFilesoption for remote inclusions and we only cache files when the property is enabled.Result
The caching can be toggled using the
cacheFilesoption