Skip to content

feat: toggle for remote inclusion caches#1413

Merged
derklaro merged 11 commits intonightlyfrom
feat/remote-inclusion-cache
Aug 10, 2024
Merged

feat: toggle for remote inclusion caches#1413
derklaro merged 11 commits intonightlyfrom
feat/remote-inclusion-cache

Conversation

@0utplay
Copy link
Member

@0utplay 0utplay commented May 25, 2024

Motivation

Some users use remote inclusions to always download latest files of certain plugins. The automatic caches makes that a bit hard.

Modification

Added a new cacheFiles option for remote inclusions and we only cache files when the property is enabled.

Result

The caching can be toggled using the cacheFiles option

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release in: node An issue/pull request releated to the node module code t: improvement The pull request improves existing code labels May 25, 2024
@0utplay 0utplay added this to the 4.0.0-RC11 milestone May 25, 2024
@0utplay 0utplay requested a review from derklaro May 25, 2024 15:02
@0utplay 0utplay self-assigned this May 25, 2024
@0utplay 0utplay requested a review from derklaro May 26, 2024 15:41
@github-actions
Copy link

github-actions bot commented May 26, 2024

Test Results

 48 files  ±0   48 suites  ±0   2m 6s ⏱️ -9s
420 tests ±0  420 ✅ ±0  0 💤 ±0  0 ❌ ±0 
751 runs  ±0  751 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2e67937. ± Comparison against base commit 18530b6.

This pull request removes 33 and adds 33 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","hello":"world","this":"is"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-07-23
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 15:57:53.417148201
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 15:57:53.417202462Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 15:57:53.417222660Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 15:57:53.417230124+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 15:57:53.417248699-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-07-23T15:57:53.417284616
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-07-23T15:57:53.417339068Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-07-23T15:57:53.416929682Z
…
eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","hello":"world","insane":"!"}}, PRETTY
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [14] 2024-08-10
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [23] 14:07:08.398088938
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [28] 14:07:08.398150493Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [29] 14:07:08.398173416Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [30] 14:07:08.398183114+05:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [31] 14:07:08.398203081-03:00
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [34] 2024-08-10T14:07:08.398257353
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [39] 2024-08-10T14:07:08.398320231Z
eu.cloudnetservice.driver.document.gson.JavaTimeSerializerTest ‑ [4] 2024-08-10T14:07:08.397848729Z
…

♻️ This comment has been updated with latest results.

@copyandexecute
Copy link

sieeeht gut aus, wird uns freuen

@copyandexecute
Copy link

passt oder

derklaro
derklaro previously approved these changes Jun 2, 2024
Copy link
Member

@derklaro derklaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good in general, just one thought: would it be better to implement equals/hashCode for inclusions specifically? I'm wondering if cacheFiles anwhere contributes anything, that would make it a requirement to include in these methods...

@0utplay 0utplay requested a review from derklaro August 9, 2024 08:24
@derklaro derklaro merged commit e91f1ea into nightly Aug 10, 2024
@derklaro derklaro deleted the feat/remote-inclusion-cache branch August 10, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: node An issue/pull request releated to the node module code t: improvement The pull request improves existing code v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants