feat: support limbo (LOOHP) minecraft servers #1412
Merged
0utplay merged 7 commits intoCloudNetService:nightlyfrom May 25, 2024
Merged
feat: support limbo (LOOHP) minecraft servers #14120utplay merged 7 commits intoCloudNetService:nightlyfrom
0utplay merged 7 commits intoCloudNetService:nightlyfrom
Conversation
0utplay
requested changes
May 23, 2024
...eu/cloudnetservice/ext/platforminject/processor/platform/limbo/LimboPluginInfoGenerator.java
Outdated
Show resolved
Hide resolved
node/src/main/java/eu/cloudnetservice/node/service/defaults/DefaultCloudServiceManager.java
Outdated
Show resolved
Hide resolved
...rc/main/java/eu/cloudnetservice/modules/bridge/platform/limbo/LimboDirectPlayerExecutor.java
Outdated
Show resolved
Hide resolved
...eu/cloudnetservice/ext/platforminject/runtime/platform/limbo/LimboPlatformPluginManager.java
Show resolved
Hide resolved
derklaro
reviewed
May 23, 2024
driver/src/main/java/eu/cloudnetservice/driver/service/ServiceEnvironmentType.java
Outdated
Show resolved
Hide resolved
0utplay
reviewed
May 24, 2024
Member
|
Is this tested? Because I think the plugin.yml won't work with that name https://github.com/LOOHP/Limbo/blob/master/src%2Fmain%2Fjava%2Fcom%2Floohp%2Flimbo%2Fplugins%2FPluginManager.java#L66 |
Contributor
Author
|
Member
|
Looks good so far. I just have one last thing. Please remove the |
0utplay
approved these changes
May 25, 2024
0utplay
changed the title
Member
|
Thanks for your contribution! |
1 task
Member
|
Fixes #1020 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Plug-and-play environment for Limbo/Auth servers, capable of hosting many players.
Modification
Modified versions file, node, platform-inject-support (processor&runtime) to support new platform.
Added new platform to bridge module.
Result
New environment can be used for services under CloudNet.
Other context
#1020