fix: ensure that npcs are removed correctly#1349
Merged
Conversation
0utplay
added
v: 4.X
Test Results 47 files 47 suites 1m 17s ⏱️ Results for commit de1fead. ♻️ This comment has been updated with latest results. |
derklaro
approved these changes
Feb 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When creating a npc on a service created from a static task, the infolines (and for entity npcs even the entity itself) are saved to the disk. After restarting the service the entity and info lines are duplicated because the plugin respawns them (as it should) but there are still the old ones from the disk.
Modification
Added a new close method to the PlatformNPCManagement. By default it removes all tracked entities (thus all info lines are removed too). The new method is called on plugin disable.
Result
No duplicates.
Other context
Fixes #1348