fix: check syncproxy perms after the player is accessible#1308
Merged
fix: check syncproxy perms after the player is accessible#1308
Conversation
0utplay
added
v: 4.X
derklaro
approved these changes
Oct 21, 2023
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The previously used LoginEvent does not provide a player instance due to the fact the there is no player at that time in the login processes. Therefore we were relying on an unsafe check using the uuid and calling the permission event ourselves.
Modification
Switched to the ServerConnectEvent which is also capable of notifying about a player connecting to the proxy itself.
Result
Permission checks with luckperms and other (non cloudperms) systems are working now too.
Other
Maybe we should consider replacing the usage of the pending connection in the cloudnet bridge too (it is not as important there because little to no one uses the bridge maintenance on the proxy)
Fixes #1069