fix: Load module dependency first by URL to inline behaviors with jup…#1259
Merged
derklaro merged 3 commits intoCloudNetService:nightlyfrom Jul 3, 2023
Merged
Conversation
0xIO32
approved these changes
Jun 30, 2023
derklaro
approved these changes
Jul 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…piter docs
Motivation
As per juppiter docs (README.md), the url field should be checked before repository scans take place, but it's the opposite in the code, causing unexpected behaviors.
On the other hand, URLs are user-defined, so they should also have a higher priority.
Modification
Changed the module dependency check order to url first then repository
Result
Behaviors are now inline with the documentations in juppiter
Other context
juppiter README.md quote:
https://github.com/CloudNetService/juppiter/blob/stable/.github/README.md?plain=1#LL107C30-L108C69