feat: enable injection of services from the service registry#1232
Merged
feat: enable injection of services from the service registry#1232
Conversation
Test Results 47 files ±0 47 suites ±0 1m 35s ⏱️ +18s Results for commit 73f5b04. ± Comparison against base commit e560b59. This pull request removes 16 and adds 17 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
derklaro
approved these changes
May 17, 2023
derklaro
pushed a commit
that referenced
this pull request
Jun 8, 2023
…#1234) ### Motivation #1232 introduced a new `@Service` annotation that allows to injection providers from the service registry directly instead of injecting the service registry and retrieving it from the registry afterwards. This PR makes use of the new annotation and replaces the service registry where possible. ### Modification Deprecated the ServiceRegistry.first(Class) method as it requires injection abuse to work. Replaced other usages of the service registry with the new annotation where possible. ### Result We are using the new Service annotation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We wanted to replace the service registry fully with injection but that would result in a weird injection tree and instead we can just make it easier to use the service registry when using injection.
Modification
Added a new
@Serviceannotation which retrieves the declared element from the service registry instead of any injection binding.Result
Injection and the service registry go hand in hand and there is no need to remove the service registry