fix: add higher priority to certain rest handlers to prevent collision#1228
Merged
fix: add higher priority to certain rest handlers to prevent collision#1228
Conversation
Test Results 47 files ±0 47 suites ±0 1m 9s ⏱️ -7s Results for commit 846c422. ± Comparison against base commit 05236d2. This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both. |
derklaro
approved these changes
May 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The bridge rest handler has routes that can collide in some situations. To prevent that we have to set a higher priority on the literal only routes.
Modification
Set a high priority on literal only routes to prevent collisions.
Result
No collisions on bridge rest routes.
Other context
Waits for #1227
Fixes #1226