Skip to content

fix: add higher priority to certain rest handlers to prevent collision#1228

Merged
derklaro merged 1 commit intonightlyfrom
bridge-rest-collision
May 16, 2023
Merged

fix: add higher priority to certain rest handlers to prevent collision#1228
derklaro merged 1 commit intonightlyfrom
bridge-rest-collision

Conversation

@0utplay
Copy link
Member

@0utplay 0utplay commented May 14, 2023

Motivation

The bridge rest handler has routes that can collide in some situations. To prevent that we have to set a higher priority on the literal only routes.

Modification

Set a high priority on literal only routes to prevent collisions.

Result

No collisions on bridge rest routes.

Other context

Waits for #1227

Fixes #1226

@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: module An issue/pull request releated to one of the internal modules labels May 14, 2023
@0utplay 0utplay added this to the 4.0.0-RC9 milestone May 14, 2023
@0utplay 0utplay requested a review from derklaro May 14, 2023 19:52
@0utplay 0utplay self-assigned this May 14, 2023
@github-actions
Copy link

Test Results

  47 files  ±0    47 suites  ±0   1m 9s ⏱️ -7s
321 tests ±0  321 ✔️ ±0  0 💤 ±0  0 ±0 
651 runs  ±0  651 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 846c422. ± Comparison against base commit 05236d2.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 15203, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] JM5AN2QTX5S3VNTNBYPVBM2FF, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] -276558892, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:5d4759e3-8365-42ec-b0c3-70c57cd39a39
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] 2394853681375571828, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] ServiceInfoSnapshot(creationTime=1683653189636, address=127.0.1.1:99, processSnapshot=ProcessSnapshot[pid=2146, cpuUsage=50.877192982456144, systemCpuUsage=100.0, maxHeapMemory=536870912, heapUsageMemory=32564064, noHeapUsageMemory=58354080, unloadedClassCount=0, totalLoadedClassCount=8529, currentLoadedClassCount=8529, threads=[ThreadSnapshot[id=1, priority=5, daemon=false, name=Test worker, threadState=RUNNABLE], ThreadSnapshot[id=2, priority=10, daemon=true, name=Reference Handler, threadState=RUNNABLE]…
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [5] 0.7950877, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [6] 0.00968161763839448, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [7] true, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [8] B, null
…
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 29206, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] PN6CP8ZOPVKSMHRJ67TEPDK9A, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 818503307, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:bb963441-f035-47cb-a29c-8f961d9e0ea5
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] 2749985340914405341, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] ServiceInfoSnapshot(creationTime=1684093913887, address=127.0.1.1:99, processSnapshot=ProcessSnapshot[pid=2063, cpuUsage=92.5, systemCpuUsage=95.23809523809523, maxHeapMemory=536870912, heapUsageMemory=26891184, noHeapUsageMemory=57486160, unloadedClassCount=1, totalLoadedClassCount=8528, currentLoadedClassCount=8527, threads=[ThreadSnapshot[id=1, priority=5, daemon=false, name=Test worker, threadState=RUNNABLE], ThreadSnapshot[id=2, priority=10, daemon=true, name=Reference Handler, threadState=RUNNABLE], …
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [5] 0.6045885, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [6] 0.9904891339154153, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [7] false, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [8] S, null
…

@derklaro derklaro merged commit b700299 into nightly May 16, 2023
@derklaro derklaro deleted the bridge-rest-collision branch May 16, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: module An issue/pull request releated to one of the internal modules t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

API: /player/onlineCount and /player/{id} overlap

2 participants