fix: make sure to create parent directories in sftp#1225
Merged
Conversation
0utplay
added
v: 4.X
derklaro
requested changes
May 16, 2023
modules/storage-sftp/src/main/java/eu/cloudnetservice/modules/sftp/SFTPTemplateStorage.java
Outdated
Show resolved
Hide resolved
derklaro
approved these changes
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When creating a new file on a sftp storage in a non existant directory the file creation will fail instead of creating the parent directories. This will result in an exception when installing a template on a sftp storage due to the creation of the config/sponge/sponge.conf file.
Modification
Made sure to create the directories before opening an outputstream or creating a file in a sftp template storage. Furthermore the tests were extended to cover the creation of files in non existant directories
Result
The parent directories are created.