feat: warn about missing manifests and main classes

[0utplay]

Motivation

If a application does not contain a manifest reading the attributes will fail as the manifest is null. Same goes for the Main-Class, if the manifest does not contain a main class the main class is passed down into the process builder as null which will result in an exception that does not say anything about the main class as it furtherdown the execution chain.

Modification

Added a new method preCheckJarManifest that takes a nullable manifest and ensures that a manifest is present and the manifest contains a main class. Otherwise two exceptions are thrown for each case.

Result

It is clear what is the issue with the application jar and the service is deleted afterwards instead of staying prepared.

[github-actions]

Test Results

  47 files  ±0    47 suites  ±0   1m 12s ⏱️ +2s
321 tests ±0  321 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
651 runs  ±0  651 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9e28c34. ± Comparison against base commit 859a7e7.

This pull request removes 16 and adds 16 tests. Note that renamed tests count towards both.

eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"insane":"!","this":"is","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 21396, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test2=test3, test=test1}, class java.lang.String, class java.lang.String
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] GJJWJUPZ3KDNG2WGMMJFEZTHM, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test2=456, test=123}, class java.lang.String, class java.lang.Integer
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] 916995999, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:0830ab70-e9ad-4796-a5ce-db4ea434ef4b
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] {test2=[678, 456], test=[123, 456]}, class java.lang.String, java.util.List<java.lang.Integer>
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] 9079842698101443442, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] Optional[{test2=test3, test=test1}], java.util.Map<java.lang.String, java.lang.String>
…

eu.cloudnetservice.driver.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","insane":"!","this":"is"}}, PRETTY
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [10] 20162, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [1] {test=test1, test2=test3}, class java.lang.String, class java.lang.String
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] LX9LPYHE5V89EDQ4JGVCJEJX5, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [2] {test=123, test2=456}, class java.lang.String, class java.lang.Integer
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] -1239873316, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] Lobbyhello156:45cc8a95-fc6f-4b53-a666-1e80604d0b17
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [3] {test=[123, 456], test2=[678, 456]}, class java.lang.String, java.util.List<java.lang.Integer>
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] -2118605919363802222, null
eu.cloudnetservice.driver.network.rpc.object.DefaultObjectMapperTest ‑ [4] Optional[{test=test1, test2=test3}], java.util.Map<java.lang.String, java.lang.String>
…

♻️ This comment has been updated with latest results.