fix: properly order console tab suggestions#1152
Merged
Conversation
derklaro
added
v: 4.X
0utplay
approved these changes
Mar 10, 2023
derklaro
added a commit
that referenced
this pull request
Mar 14, 2023
### Motivation The current candidate matching system in CloudNet is using a jaro winkler distance to check if a possible suggestion matches the given started input and sorts the values based on the algorithm result. That ordering is not properly kept after passing the candidates to jline. ### Modification Set the sort of the candidates that are passed to jline. This will keep the candidates in the order given from the called tab complete handler. ### Result JLine now displays the tab completions for a command in the intended order. ##### Other context Before:  After: 
derklaro
added a commit
that referenced
this pull request
Apr 17, 2023
### Motivation The current candidate matching system in CloudNet is using a jaro winkler distance to check if a possible suggestion matches the given started input and sorts the values based on the algorithm result. That ordering is not properly kept after passing the candidates to jline. ### Modification Set the sort of the candidates that are passed to jline. This will keep the candidates in the order given from the called tab complete handler. ### Result JLine now displays the tab completions for a command in the intended order. ##### Other context Before:  After: 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current candidate matching system in CloudNet is using a jaro winkler distance to check if a possible suggestion matches the given started input and sorts the values based on the algorithm result. That ordering is not properly kept after passing the candidates to jline.
Modification
Set the sort of the candidates that are passed to jline. This will keep the candidates in the order given from the called tab complete handler.
Result
JLine now displays the tab completions for a command in the intended order.
Other context
Before:
After:
