Conversation
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
- Coverage 70.33% 65.27% -5.06%
==========================================
Files 17 17
Lines 1847 1846 -1
==========================================
- Hits 1299 1205 -94
- Misses 548 641 +93
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Contributor
|
Geopandas and seaborn were both used in the diagnostics module that has since been moved to dscim-cil (so are probably good to be removed as requirements). I assume that click was intended for the original dscim waiter and is also good to be removed. I'm not sure what the original uses for the other packages were. |
Member
Author
|
Coverage is decreased because CI is now skipping some of the RFF tests because |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drops requirements listed in README and requirements.txt that dscim does not appear to use or are optional.
Dropped packages are:
Updated README and CHANGELOG.