Skip to content

Drop requirements that appear unused#99

Merged
brews merged 8 commits intomainfrom
cruft_reqs
Aug 3, 2023
Merged

Drop requirements that appear unused#99
brews merged 8 commits intomainfrom
cruft_reqs

Conversation

@brews
Copy link
Copy Markdown
Member

@brews brews commented Jul 17, 2023

Drops requirements listed in README and requirements.txt that dscim does not appear to use or are optional.

Dropped packages are:

  • click
  • dask-jobqueue
  • geopandas
  • gurobipy
  • ipywidgets
  • seaborn

Updated README and CHANGELOG.

@brews brews added the documentation Improvements or additions to documentation label Jul 17, 2023
@brews brews requested a review from JMGilbert July 17, 2023 21:41
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 17, 2023

Codecov Report

Merging #99 (6e35a37) into main (9ce9cb5) will decrease coverage by 5.06%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
- Coverage   70.33%   65.27%   -5.06%     
==========================================
  Files          17       17              
  Lines        1847     1846       -1     
==========================================
- Hits         1299     1205      -94     
- Misses        548      641      +93     
Files Changed Coverage Δ
src/dscim/utils/rff.py 42.24% <0.00%> (-49.78%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@brews brews added the help wanted Extra attention is needed label Jul 20, 2023
@brews brews requested a review from kemccusker July 20, 2023 20:40
@JMGilbert
Copy link
Copy Markdown
Contributor

Geopandas and seaborn were both used in the diagnostics module that has since been moved to dscim-cil (so are probably good to be removed as requirements). I assume that click was intended for the original dscim waiter and is also good to be removed. I'm not sure what the original uses for the other packages were.

@brews brews added enhancement New feature or request and removed help wanted Extra attention is needed labels Aug 3, 2023
@brews
Copy link
Copy Markdown
Member Author

brews commented Aug 3, 2023

Coverage is decreased because CI is now skipping some of the RFF tests because gurobipy isn't installed. That's expected.

@brews brews merged commit b24b214 into main Aug 3, 2023
@brews brews deleted the cruft_reqs branch August 3, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants