Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dscim-v0.4.0_fixes #84 +/- ##
======================================================
+ Coverage 68.15% 70.28% +2.12%
======================================================
Files 17 17
Lines 1878 1878
======================================================
+ Hits 1280 1320 +40
+ Misses 598 558 -40 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kemccusker
approved these changes
Jun 28, 2023
Member
kemccusker
left a comment
kemccusker
left a comment
There was a problem hiding this comment.
LGTM. For future, let's revisit the tolerances on the SCGHG test and whether we want to update that.
Member
|
Revisit tolerances in a later PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.