Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## dscim-v0.4.0 #79 +/- ##
=============================================
Coverage 40.53% 40.53%
=============================================
Files 18 18
Lines 1838 1838
=============================================
Hits 745 745
Misses 1093 1093
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@JMGilbert at some point we no longer needed any masking and simplified the naming/dir structures by removing it, I thought. But is that directory structure (with the "mask" argument) expected somewhere else in the code and that's what this fix is for? |
|
In late summer 2022, we changed the structure of the rff SCC results to reflect the structure of the ar6 results, which includes a subdirectory for masks. This is the one place that still expects a subdirectory with no masking. After meeting, we have decided to keep the masked structure for rff (even though that functionality is not needed) so that the structures of all DSCIM results are the same. |
The
rff_damage_functionsfunction was previously reading SSP damage functions from a filepath that did not include the mask and saving out to a filepath not including the mask. This required manual moving of damage functions before and after this function was run. These changes should restore full automation to the input damage -> SCC pipeline.