Skip to content

Fix damage function paths#79

Merged
JMGilbert merged 2 commits intodscim-v0.4.0from
fix_damage_fun_paths
Mar 30, 2023
Merged

Fix damage function paths#79
JMGilbert merged 2 commits intodscim-v0.4.0from
fix_damage_fun_paths

Conversation

@JMGilbert
Copy link
Copy Markdown
Contributor

The rff_damage_functions function was previously reading SSP damage functions from a filepath that did not include the mask and saving out to a filepath not including the mask. This required manual moving of damage functions before and after this function was run. These changes should restore full automation to the input damage -> SCC pipeline.

@JMGilbert JMGilbert changed the base branch from main to dscim-v0.4.0 March 23, 2023 17:01
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #79 (899f59e) into dscim-v0.4.0 (f5d88b2) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff              @@
##           dscim-v0.4.0      #79   +/-   ##
=============================================
  Coverage         40.53%   40.53%           
=============================================
  Files                18       18           
  Lines              1838     1838           
=============================================
  Hits                745      745           
  Misses             1093     1093           
Impacted Files Coverage Δ
src/dscim/utils/rff.py 0.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JMGilbert JMGilbert marked this pull request as ready for review March 23, 2023 17:09
@kemccusker
Copy link
Copy Markdown
Member

@JMGilbert at some point we no longer needed any masking and simplified the naming/dir structures by removing it, I thought. But is that directory structure (with the "mask" argument) expected somewhere else in the code and that's what this fix is for?

@JMGilbert
Copy link
Copy Markdown
Contributor Author

In late summer 2022, we changed the structure of the rff SCC results to reflect the structure of the ar6 results, which includes a subdirectory for masks. This is the one place that still expects a subdirectory with no masking. After meeting, we have decided to keep the masked structure for rff (even though that functionality is not needed) so that the structures of all DSCIM results are the same.

@JMGilbert JMGilbert merged commit 247a81e into dscim-v0.4.0 Mar 30, 2023
@JMGilbert JMGilbert deleted the fix_damage_fun_paths branch March 30, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants