Skip to content

new process coastal inputs function#75

Merged
kemccusker merged 5 commits intodscim-v0.4.0from
new_process_coastal_inputs_function
Apr 6, 2023
Merged

new process coastal inputs function#75
kemccusker merged 5 commits intodscim-v0.4.0from
new_process_coastal_inputs_function

Conversation

@davidrzhdu
Copy link
Copy Markdown
Contributor

No description provided.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 7, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dscim-v0.4.0@cca3ddb). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dscim-v0.4.0      #75   +/-   ##
===============================================
  Coverage                ?   40.40%           
===============================================
  Files                   ?       18           
  Lines                   ?     1844           
  Branches                ?        0           
===============================================
  Hits                    ?      745           
  Misses                  ?     1099           
  Partials                ?        0           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JMGilbert
Copy link
Copy Markdown
Contributor

I think rather than a try except block it's better practice to just check if vsl_valuation is a coordinate of the dataset like so:

if "vsl_valuation" in d.coords:
    ...
else:
    ...

@kemccusker kemccusker merged commit eef0eb4 into dscim-v0.4.0 Apr 6, 2023
@kemccusker kemccusker deleted the new_process_coastal_inputs_function branch April 6, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants