Skip to content

Package cleaning#57

Merged
JMGilbert merged 8 commits intomainfrom
package_cleaning
Nov 10, 2022
Merged

Package cleaning#57
JMGilbert merged 8 commits intomainfrom
package_cleaning

Conversation

@JMGilbert
Copy link
Copy Markdown
Contributor

Deleting unused files

Copy link
Copy Markdown
Member

@brews brews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see code cleanup, @JMGilbert 👍

If this removes all of cli, then I think we can remove the click package as a dependency in README.md and requirements.txt. I'd consider including those changes in this PR and maybe noting that we're dropping the CLI in CHANGELOG... I don't know if anyone is actually using it or would look for it again in the future. I feel like y'all would be better judges of that over me.

@kemccusker, @JMGilbert I see this takes care of fair. I also had a note about possibly removing diagnostics. Is that something you'd want to do here or is that a change for another time?

That's my only thought. I think this looks good-to-go otherwise.

@kemccusker
Copy link
Copy Markdown
Member

@brews we will take care of cleaning up diagnostics in a later PR

@JMGilbert JMGilbert merged commit 5aa3b72 into main Nov 10, 2022
@JMGilbert JMGilbert deleted the package_cleaning branch November 10, 2022 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants