Skip to content

Fix pathlib.Path/str TypeError in preprocessing.clip_damages()#55

Merged
brews merged 4 commits intomainfrom
fix_path
Sep 29, 2022
Merged

Fix pathlib.Path/str TypeError in preprocessing.clip_damages()#55
brews merged 4 commits intomainfrom
fix_path

Conversation

@brews
Copy link
Copy Markdown
Member

@brews brews commented Sep 28, 2022 •
edited
Loading

Minor fix. Looks like a pathlib.Path was being treated like a str.

Also renamed the path variable to sector_path to avoid confusion between path and Path, which are both used in the function.

close #36

@brews brews added the bug Something isn't working label Sep 28, 2022
@brews brews self-assigned this Sep 28, 2022
@brews brews changed the title Draft: Fix bad args to path.replace() will raise TypeError in preprocessing.clip_damages() Draft: Fix pathlib.Path/str TypeError in preprocessing.clip_damages() Sep 28, 2022
@brews brews changed the title Draft: Fix pathlib.Path/str TypeError in preprocessing.clip_damages() Fix pathlib.Path/str TypeError in preprocessing.clip_damages() Sep 28, 2022
@brews brews requested a review from kemccusker September 28, 2022 22:49
kemccusker
kemccusker reviewed Sep 29, 2022
View reviewed changes
@brews brews merged commit 6fc7714 into main Sep 29, 2022
@brews brews deleted the fix_path branch September 29, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kemccusker kemccusker kemccusker approved these changes

Assignees

@brews brews

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad args to path.replace() will raise TypeError in preprocessing.clip_damages()

2 participants

@brews @kemccusker