Conversation
This adds a test covering the behavior where we need to swap out the deprecated method. Just in case.
brews
changed the title
.drop() deprecation
Member
Author
|
CI tests are failing I'm missing something obvious here. Edit: Fixed. |
The key here is that the variables needs to be dropped, not the dimension. I'm not sure whether or not this is intended but it makes current behavior consistent with the past.
brews
changed the title
.drop() deprecation.drop() deprecation
kemccusker
reviewed
Sep 29, 2022
kemccusker
approved these changes
Sep 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xarrayis deprecating.drop()so we're getting warnings about it. This fixes the problem by changing it for the recommended.drop_vars().This also adds a test covering the behavior where this swap needs to occur. Not the greatest test but just in case.
Close #37