Add new unit tests for basic behaviors in simple_storage EconVars and Climate, fix docstr#50
Merged
Add new unit tests for basic behaviors in simple_storage EconVars and Climate, fix docstr#50
Conversation
Testing for what I'm seeing as some basic behaviors.
Testing for what I'm seeing as some basic behaviors, focusing on EPA prototype parameters for input.
brews
changed the title
brews
added
documentation
brews
changed the title
kemccusker
reviewed
Sep 23, 2022
| # This struction might appear weird, but matches that used for initial EPA estimates. | ||
| ds_in = xr.Dataset( | ||
| { | ||
| "__xarray_dataarray_variable__": (["gas"], test_numbers), |
Member
There was a problem hiding this comment.
oh yeah, we should update that file it looks like
JMGilbert
pushed a commit
that referenced
this pull request
Jan 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding new unit tests to explicitly cover some basic behaviors that I'm seeing in how the package is used for EPA prototype. Specifically, this improves testing for
ClimateandEconVarsindscim.menu.simple_storage.Includes a minor docstr fix to
Climate. The "ecs_mask*" arguments look like they can sometimes beNoneand optional. Updated to show that.