Conversation
|
I'm not entirely confident in my explanations here, so feedback would be greatly appreciated. |
brews
left a comment
brews
left a comment
There was a problem hiding this comment.
Thanks for turning this around @JMGilbert. It's small but this helps clarify things. I have very minor edits. I'm curious to see how @kemccusker would word that new docstr line. I'd wait for feedback from her before merging.
src/dscim/menu/simple_storage.py
Outdated
| emission_scenarios: list or None, optional | ||
| List of emission scenarios for which SCC will be calculated. Default | ||
| is (), which gets set to ["ssp119", "ssp126", "ssp245", "ssp460", "ssp370", "ssp585"]. | ||
| emission_scenarios should be None when rcp is not the source of emission scenarios and thus can't be selected. |
There was a problem hiding this comment.
@JMGilbert Yeah, this one is tricky. What do you think, @kemccusker?
I came up with this. Not sure it's better:
| emission_scenarios should be None when rcp is not the source of emission scenarios and thus can't be selected. | |
| Use `None` when RCP emission scenarios are not part of climate projections, | |
| such as with RFF projections. |
There was a problem hiding this comment.
@JMGilbert @brews Thanks this is great. I think I'd update Brewster's suggestion a little bit to
Use `None` when RCP emission scenarios are not the climate projections,
such as with RFF-SP projections.
Ultimately, I think we should probably label the RFF-SP projections too (as we do the ssp-rcps) so that we don't have to rely on None. For the RFF projections we run, I would use "RFF-SPv2". That would be a future update though.
Co-authored-by: Brewster Malevich <bmalevich@rhg.com>
3 participants
Include the bugfix to the changelog and the reason for the bugfix to the docstring.