Conversation
brews
changed the title
brews
changed the title
brews
changed the title
kemccusker
reviewed
Sep 16, 2022
kemccusker
reviewed
Sep 16, 2022
kemccusker
reviewed
Sep 16, 2022
kemccusker
approved these changes
Sep 16, 2022
Member
kemccusker
left a comment
kemccusker
left a comment
There was a problem hiding this comment.
@brews thank you so much for catching these gotchas and updating them. The changes look good to me. I'm eager to make sure they don't introduce any issues in replication, but I think it's unlikely
Member
Author
|
@kemccusker Yeah, these appeared straightforward. Unit tests ran and passed without issue, so 👍. I'm going to merge this so we can keep rolling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bunch of small fixes to avoid future bugs from the "mutable defaults" gotcha. I am not aware of errors in current runs because of this, though.