Conversation
Convert old %-string formatting to use preferred f-strings. This update is required for ruff check 0.8.x.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 68.91% 68.91%
=======================================
Files 15 15
Lines 1750 1750
=======================================
Hits 1206 1206
Misses 544 544 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@JMGilbert tapping you for review on this, but I know you're busy. Appreciate your help. This should not take more than 5 minutes. It's a very small update to code syntax. Ruff was suggesting a change to keep up with Python best practices as the language evolves. |
Contributor
|
I'm surprised we had and % strings left. Happy to make the full official switch to f strings! |
JMGilbert
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor update converting % string formatting to use newer recommended f-string formatting. It's now a best practice. Should be easier to read.
This should have no change on package functionality.
This also bumps ruff to 0.8.x, which recommended the change when Dependabot tried to bump it in #348.