Skip to content

Upgrade CI Python version to >= 3.12#270

Merged
brews merged 1 commit intomainfrom
bump_ci_py
Jun 4, 2024
Merged

Upgrade CI Python version to >= 3.12#270
brews merged 1 commit intomainfrom
bump_ci_py

Conversation

@brews
Copy link
Copy Markdown
Member

@brews brews commented May 30, 2024

CI previously ran on Python 3.10. This upgrades it to 3.12.

Close #150

@brews brews self-assigned this May 30, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (8c3e7c5) to head (4e950d4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #270   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files          15       15           
  Lines        1750     1750           
=======================================
  Hits         1206     1206           
  Misses        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brews brews marked this pull request as ready for review May 30, 2024 23:15
@brews
Copy link
Copy Markdown
Member Author

brews commented May 30, 2024

Heads up to @JMGilbert @kemccusker. It's good to test on a recent version of Python. Any concerns with running CI tests on Python 3.12?

@kemccusker
Copy link
Copy Markdown
Member

Heads up to @JMGilbert @kemccusker. It's good to test on a recent version of Python. Any concerns with running CI tests on Python 3.12?

None that I can think of, except we may pin to earlier versions of python in calling applications, but those are also pinned to earlier versions of dscim so I think it's fine.

@brews
Copy link
Copy Markdown
Member Author

brews commented Jun 4, 2024

Thanks, @kemccusker. To be clear this doesn't make Python >= 3.12 a requirement for users installing the package. It's just the Python version CI tests on.

@brews brews merged commit e82a6be into main Jun 4, 2024
brews added a commit that referenced this pull request Jun 4, 2024
@brews brews deleted the bump_ci_py branch June 13, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add or update CI tests to use Python >=3.11

2 participants