Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 65.63% 68.91% +3.27%
==========================================
Files 17 15 -2
Lines 1845 1750 -95
==========================================
- Hits 1211 1206 -5
+ Misses 634 544 -90 ☔ View full report in Codecov by Sentry. |
kemccusker
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deals with:
mortality_inputs_archived.pyis a function call [will be moved when new format mortality inputs are figured out]generate_yaml.pydoesn't seem necessaryplotting_utils.pydoesn't seem necessaryupdate_damage_function_library()old function can just be removed (not currently in use)constant_equivalent_discount_rate()andcalculate_constant_equivalent_discount_rate()seem like diagnostic functionsget_model_weights()references Battuta file path and also is mostly used for diagnostics outside ofdscimitselfdscim-cilfor diagnosticsdscim/preprocessing/miscanddscim/preprocessing/climatehave lots of hardcoded filepaths. Seems like we want many of these scripts, but they should be integrated into our climate/socioeconomic modules in the futureconvert_float32.pyis entirely unused anywhere, it seems to have been used originally to convert the ag damages to float32 from float64 (deleted)bottom_code_econ_zarr.pytransferred to dscim-cilcheck_nans.pytransferred to dscim-cilall_masks_rff.pydeleting because we don’t use masks for rff, happy to move somewhere if we actually want itssp_clipped_rff.pysome kind of diagnostic to mask runids based on max and min SSP values for gdp,pop. Deleting unless we want it for somethingstack_iterations.pyI really don’t know what this was for, but now I think our iterations come stacked, deleting (probably dealt with old climate data withiterdimension)stack_masks.pyI really don’t know, deleting (probably used for ease of diagnostics when we used masks, which we no longer use)