Skip to content

Clean dscim#249

Merged
kemccusker merged 9 commits intomainfrom
clean_dscim
May 28, 2024
Merged

Clean dscim#249
kemccusker merged 9 commits intomainfrom
clean_dscim

Conversation

@JMGilbert
Copy link
Copy Markdown
Contributor

@JMGilbert JMGilbert commented Apr 25, 2024

This PR deals with:

  • mortality_inputs_archived.py is a function call [will be moved when new format mortality inputs are figured out]
    • deleted
  • generate_yaml.py doesn't seem necessary
    • deleted
  • plotting_utils.py doesn't seem necessary
    • plotting utils only used in one place
    • copy and pasted into the notebook that called it
  • update_damage_function_library() old function can just be removed (not currently in use)
    • deleted
  • constant_equivalent_discount_rate() and calculate_constant_equivalent_discount_rate() seem like diagnostic functions
    • used for integration paper tables here
    • moved to a script in dscim-diagnostics in dscim-cil
  • get_model_weights() references Battuta file path and also is mostly used for diagnostics outside of dscim itself
    • used in dscim-cil for diagnostics
    • moved to a script in dscim-diagnostics in dscim-cil
  • dscim/preprocessing/misc and dscim/preprocessing/climate have lots of hardcoded filepaths. Seems like we want many of these scripts, but they should be integrated into our climate/socioeconomic modules in the future
    • ALL BELOW DELETED/MOVED
    • misc:
      • convert_float32.py is entirely unused anywhere, it seems to have been used originally to convert the ag damages to float32 from float64 (deleted)
      • bottom_code_econ_zarr.py transferred to dscim-cil
      • check_nans.py transferred to dscim-cil
    • climate:
      • all_masks_rff.py deleting because we don’t use masks for rff, happy to move somewhere if we actually want it
      • ssp_clipped_rff.py some kind of diagnostic to mask runids based on max and min SSP values for gdp,pop. Deleting unless we want it for something
      • stack_iterations.py I really don’t know what this was for, but now I think our iterations come stacked, deleting (probably dealt with old climate data with iter dimension)
      • stack_masks.py I really don’t know, deleting (probably used for ease of diagnostics when we used masks, which we no longer use)

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (25dfb39) to head (f16b308).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   65.63%   68.91%   +3.27%     
==========================================
  Files          17       15       -2     
  Lines        1845     1750      -95     
==========================================
- Hits         1211     1206       -5     
+ Misses        634      544      -90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JMGilbert JMGilbert requested a review from kemccusker April 26, 2024 16:09
@kemccusker kemccusker merged commit 5a72e74 into main May 28, 2024
@kemccusker kemccusker deleted the clean_dscim branch May 28, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants