Conversation
e378801 to
032687d
Compare
032687d to
b315363
Compare
Bumps [pandas](https://github.com/pandas-dev/pandas) from 2.1.4 to 2.2.1. - [Release notes](https://github.com/pandas-dev/pandas/releases) - [Commits](pandas-dev/pandas@v2.1.4...v2.2.1) --- updated-dependencies: - dependency-name: pandas dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
b315363 to
e744061
Compare
|
Ah, sorry, I marked you as reivewer @kemccusker because I got the update on the issue. I don't mind merging this but wasn't sure if you already wanted to handle this one. If you weren't already planning it, could you take 5 minutes and review this before the end of the week, @kemccusker? |
brews
left a comment
There was a problem hiding this comment.
Appreciate the fix!
I might suggest adding a comment to each of the tests that needed changing explaining why all this sorting and index shuffling is needed. I feel like I wouldn't be able to grok what's going on (or the "why" of it) if I was reading through the tests.
|
First, sorry for the spam. If you haven't already tried it, you might be able to ditch some or all of the index/column ordering I've been complaining about by passing |
This works, but requires setting the indices of both dataframes, something like: Maybe we should be actually using the index dimensions (like ssp, gcm, etc) as pandas indices in the first place. |
|
@JMGilbert I like the idea to |
|
@JMGilbert Is the index information you're setting something already available in all the "expected" files used for the test, but not set as the index by |
|
Ahhhh. I see what's going on. I was totally misreading the issue. I tried your solution @JMGilbert and I think it works great. Thank you for being patient with me everyone. I did it like: |
Bumps pandas from 2.1.4 to 2.2.1.
Release notes
Sourced from pandas's releases.
... (truncated)
Commits
bdc79c1RLS: 2.2.1470b886Backport PR #57582 on branch 2.2.x (DOC: Add contributors for 2.2.1) (#57583)541448eRLS: 2.2.1bdbb179Backport PR #57576 on branch 2.2.x (DOC: Add release date for 2.2.1) (#57579)5521dc9Backport PR #57314 on branch 2.2.x (BUG: Fix near-minimum timestamp handling)...ea56e0cBackport PR #57556 on branch 2.2.x (Remove PyArrow deprecation warning) (#57568)3bfedfeBackport PR #57551: BLD: Add pyarrow extra for pip installation (#57557)3a4033cBackport PR #57439 on branch 2.2.x (BUG: read_json returning Index instead of...c101d30Backport PR #57510 on branch 2.2.x (DOC: Fix xarray example) (#57538)0b49cf3Backport PR #57536 on branch 2.2.x (BUG: dt64 + DateOffset with milliseconds)...You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)