Merged
Conversation
kemccusker
reviewed
Nov 17, 2023
| ) | ||
| else: | ||
| pass | ||
| anomaly = xr.open_dataset(self.gmsl_fair_path) |
Member
There was a problem hiding this comment.
love when we can replace a bunch of yuck with 2 lines
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
==========================================
- Coverage 65.30% 65.12% -0.19%
==========================================
Files 17 17
Lines 1842 1832 -10
==========================================
- Hits 1203 1193 -10
Misses 639 639 ☔ View full report in Codecov by Sentry. |
kemccusker
approved these changes
Nov 18, 2023
Member
kemccusker
left a comment
kemccusker
left a comment
There was a problem hiding this comment.
Looks good, thanks @JMGilbert !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary dimensions from gmst/gmsl pulse files. This means removing the "simulation" dimension for RFF as well as making the "control" runtype a separate variable only indexed by pulse year, year, and runid/sample.