Conversation
Codecov Report
@@ Coverage Diff @@
## main #129 +/- ##
=======================================
Coverage 65.30% 65.30%
=======================================
Files 17 17
Lines 1842 1842
=======================================
Hits 1203 1203
Misses 639 639
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
One of the fixes here is that you can no longer index with a dask-backed boolean array. Rather than refactoring I simply tacked on a
risks using too much memory if the input array is larger than memory. I don't know if large input arrays is a real problem here? I'd love for feedback on this. |
|
While I'm thinking about it. Maybe we can replace all these if (array <= 0).any():
raise ValueError("Values in array are <= 0") |
|
@kemccusker I did a full run through from reduced damages using this PR and replicated both risk aversion euler ramsey and equity euler ramsey. |
Thanks, @JMGilbert !! |
Fix stuff so can run latest xarray v2023.8.0. Right now it depends on a version from about a year ago.
Close #103