Refactor theme structure and update imports #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved ClickUIProvider and theme variable files to a new src/theme directory. Updated all relevant imports in components and theme index to use the new paths. Added a new Theme type definition and separated theme variable JSON files for dark, light, and default themes.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
|
@serdec Can I get a second pair of eyes on this please? It's not enough to simply move the variables directory in the code as unless I make changes at the token creation end, it'll just overwrite them again. Can you double check the build work with style directory that we set up to make sure we're not breaking things with this PR? Screenshot from Tokens Studio, check the bottom field.
|
Changed the import path for ClickUIProvider in .storybook/preview.tsx to reflect its new location under src/theme. This ensures Storybook uses the correct provider component.
Reformats TypeScript interface declarations across multiple components for improved readability and consistency, primarily by moving 'extends' and generic type parameters to a single line or consistent multi-line style. Also updates Prettier to version 3.7.4 in package.json and yarn.lock.
ariser
previously approved these changes
Dec 16, 2025
ariser
dismissed
their stale review
the code changes themselves look fine, but apparently we need to double check what Gareth said
Moved ClickUIProvider and theme variable files to a new src/theme directory. Updated all relevant imports in components and theme index to use the new paths. Added a new Theme type definition and separated theme variable JSON files for dark, light, and default themes.
Changed the import path for ClickUIProvider in .storybook/preview.tsx to reflect its new location under src/theme. This ensures Storybook uses the correct provider component.
…m/ClickHouse/click-ui into theme-related-folder-optimization
Theme token files and types have been moved from src/styles to src/theme/tokens for better organization. The build-tokens.js script and related build paths were updated accordingly, and the generate-tokens script now formats the generated TypeScript file with Prettier. Old files in src/styles were deleted.
Collaborator
Author
Member
|
@gjones it should be ok and the changes shouldn't break anything |
serdec
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved ClickUIProvider and theme variable files to a new src/theme directory. Updated all relevant imports in components and theme index to use the new paths. Added a new Theme type definition and separated theme variable JSON files for dark, light, and default themes.
The main purpose is to move all the theme related items in a single folder for better readability