Skip to content

test(ci): upload CI test results to codecov#6749

Merged
LesnyRumcajs merged 1 commit intomainfrom
hm/junit-test-results
Mar 16, 2026
Merged

test(ci): upload CI test results to codecov#6749
LesnyRumcajs merged 1 commit intomainfrom
hm/junit-test-results

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Mar 16, 2026

Summary of changes

test results uploaded to https://app.codecov.io/gh/ChainSafe/forest/tests/hm%2Fjunit-test-results

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Tests
    • Added a dedicated JUnit test output so test results are consistently produced.
    • CI now uploads test results to Codecov, improving visibility of test outcomes and coverage.
    • Enhances overall test reporting and tracking across runs for more reliable feedback.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 50c887d5-1566-4a7d-8af9-111db4952141

📥 Commits

Reviewing files that changed from the base of the PR and between 817fdd6 and 1b242cc.

📒 Files selected for processing (2)
  • .config/nextest.toml
  • .github/workflows/unit-tests.yml
🚧 Files skipped from review as they are similar to previous changes (1)
  • .config/nextest.toml

Walkthrough

Adds a Nextest JUnit output path to .config/nextest.toml and a Codecov upload step to the .github/workflows/unit-tests.yml CI workflow that uploads target/nextest/default/junit.xml via codecov-action@v5.

Changes

Cohort / File(s) Summary
Nextest config
.config/nextest.toml
Adds [profile.default.junit] with path = "junit.xml" to declare JUnit output path for Nextest.
CI workflow
.github/workflows/unit-tests.yml
Adds a step "Upload Test Results to CodeCov" using codecov-action@v5, conditional on non-cancelled runs, uploads target/nextest/default/junit.xml and uses CODECOV_TOKEN.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding CI integration to upload test results to Codecov, which is supported by changes in both the nextest config and GitHub Actions workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/junit-test-results
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch hm/junit-test-results
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 force-pushed the hm/junit-test-results branch from 504b45c to 817fdd6 Compare March 16, 2026 12:31
@hanabi1224 hanabi1224 marked this pull request as ready for review March 16, 2026 12:31
@hanabi1224 hanabi1224 requested a review from a team as a code owner March 16, 2026 12:31
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and akaladarshi and removed request for a team March 16, 2026 12:31
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/workflows/unit-tests.yml:
- Around line 86-92: The "Upload Test Results to CodeCov" job step currently
runs only on success; modify that step (the step named "Upload Test Results to
CodeCov" that uses codecov/codecov-action@v5 and uses token: ${{
secrets.CODECOV_TOKEN }}) to include an if: condition so it runs on both success
and failure (but not on manual cancel), e.g. add if: "!cancelled()" to the step
declaration so test results are uploaded even when tests fail.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 5da2b32c-930f-4fea-b2fb-c04b48598a9c

📥 Commits

Reviewing files that changed from the base of the PR and between a3f7804 and 817fdd6.

📒 Files selected for processing (2)
  • .config/nextest.toml
  • .github/workflows/unit-tests.yml

@hanabi1224 hanabi1224 force-pushed the hm/junit-test-results branch from 817fdd6 to feb0229 Compare March 16, 2026 12:36
@hanabi1224 hanabi1224 force-pushed the hm/junit-test-results branch from feb0229 to 1b242cc Compare March 16, 2026 12:36
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit 1e0a5c5 Mar 16, 2026
36 of 37 checks passed
@LesnyRumcajs LesnyRumcajs deleted the hm/junit-test-results branch March 16, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants