Skip to content

test: add lotus-gateway parity test#6570

Merged
hanabi1224 merged 7 commits intomainfrom
hm/api-compare-gateway
Feb 11, 2026
Merged

test: add lotus-gateway parity test#6570
hanabi1224 merged 7 commits intomainfrom
hm/api-compare-gateway

Conversation

@hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Feb 9, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • Chores
    • Updated test infrastructure configuration with new environment variables.
    • Enhanced API compatibility testing with new gateway-based test workflows and improved service orchestration.
    • Added comprehensive documentation of gateway API method support and compatibility status.

@hanabi1224 hanabi1224 added the RPC requires calibnet RPC checks to run on CI label Feb 9, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

Walkthrough

The PR extends the API comparison testing infrastructure to support lotus-gateway testing by updating environment variables, adding new Docker services for gateway-based API comparisons, and introducing a filter list for unsupported/broken gateway methods.

Changes

Cohort / File(s) Summary
Environment Configuration
scripts/tests/api_compare/.env
Updated LOTUS_IMAGE from v1.34.4-rc1-calibnet to v1.34.4-calibnet; added FOREST_VIA_GATEWAY_RPC_PORT=4567.
Docker Orchestration
scripts/tests/api_compare/docker-compose.yml
Added three new services: forest-via-gateway (runs lotus-gateway with health checks), api-compare-gateway (compares gateway APIs with multi-service dependencies), and forest-shutdown (cleanup service). Removed F3 certificate wait loop; restructured service dependencies and coordination.
Gateway Filtering
scripts/tests/api_compare/filter-list-gateway
New static file defining unsupported and broken Filecoin API methods for lotus-gateway (67 lines across two categorized sections).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

Possibly related PRs

Suggested reviewers

  • sudo-shashank
  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'test: add lotus-gateway parity test' directly and concisely describes the main change: adding a new test for lotus-gateway parity compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch hm/api-compare-gateway

Comment @coderabbitai help to get the list of available commands and usage tips.

@hanabi1224 hanabi1224 marked this pull request as ready for review February 10, 2026 06:45
@hanabi1224 hanabi1224 requested a review from a team as a code owner February 10, 2026 06:45
@hanabi1224 hanabi1224 requested review from LesnyRumcajs and removed request for a team February 10, 2026 06:45
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Fix all issues with AI agents
In `@scripts/tests/api_compare/.env`:
- Around line 2-10: The .env file has dotenv-linter ordering warnings for keys
such as FOREST_IMAGE, LOTUS_IMAGE, FIL_PROOFS_PARAMETER_CACHE, LOTUS_RPC_PORT,
FOREST_RPC_PORT, FOREST_OFFLINE_RPC_PORT, FOREST_VIA_GATEWAY_RPC_PORT,
FOREST_HEALTHZ_RPC_PORT and CHAIN; fix by reordering the entries into the
linter-expected order (e.g., alphabetically by key) so keys like CHAIN,
FIL_PROOFS_PARAMETER_CACHE, FOREST_HEALTHZ_RPC_PORT, FOREST_IMAGE,
FOREST_OFFLINE_RPC_PORT, FOREST_RPC_PORT, FOREST_VIA_GATEWAY_RPC_PORT,
LOTUS_IMAGE, LOTUS_RPC_PORT appear in sorted order to remove the dotenv-linter
noise. Ensure no values or spacing are changed beyond reordering.

In `@scripts/tests/api_compare/docker-compose.yml`:
- Around line 314-338: The docker-compose teardown service forest-shutdown never
runs on test failures because api-compare doesn't reach
service_completed_successfully; update the test orchestration to guarantee
cleanup by either adding the --abort-on-container-exit flag to the docker
compose invocation in setup.sh so compose will shut down all containers when any
exits, or add a process-level fallback trap in api_compare.sh (e.g., trap on
EXIT) that invokes docker compose down to ensure the forest container is
stopped; pick one approach and implement it so forest-shutdown is not relied on
as the sole cleanup path.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.33%. Comparing base (0e6c181) to head (1a4802b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files

see 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6c181...1a4802b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LesnyRumcajs
Copy link
Member

no green checkmark! ❌

@hanabi1224
Copy link
Contributor Author

no green checkmark! ❌

@LesnyRumcajs all green now!

@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Feb 10, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 10, 2026
@hanabi1224 hanabi1224 added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit bdccc7a Feb 11, 2026
83 of 86 checks passed
@hanabi1224 hanabi1224 deleted the hm/api-compare-gateway branch February 11, 2026 00:18
@coderabbitai coderabbitai bot mentioned this pull request Mar 2, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants