Conversation
WalkthroughThe PR extends the API comparison testing infrastructure to support lotus-gateway testing by updating environment variables, adding new Docker services for gateway-based API comparisons, and introducing a filter list for unsupported/broken gateway methods. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related issues
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@scripts/tests/api_compare/.env`:
- Around line 2-10: The .env file has dotenv-linter ordering warnings for keys
such as FOREST_IMAGE, LOTUS_IMAGE, FIL_PROOFS_PARAMETER_CACHE, LOTUS_RPC_PORT,
FOREST_RPC_PORT, FOREST_OFFLINE_RPC_PORT, FOREST_VIA_GATEWAY_RPC_PORT,
FOREST_HEALTHZ_RPC_PORT and CHAIN; fix by reordering the entries into the
linter-expected order (e.g., alphabetically by key) so keys like CHAIN,
FIL_PROOFS_PARAMETER_CACHE, FOREST_HEALTHZ_RPC_PORT, FOREST_IMAGE,
FOREST_OFFLINE_RPC_PORT, FOREST_RPC_PORT, FOREST_VIA_GATEWAY_RPC_PORT,
LOTUS_IMAGE, LOTUS_RPC_PORT appear in sorted order to remove the dotenv-linter
noise. Ensure no values or spacing are changed beyond reordering.
In `@scripts/tests/api_compare/docker-compose.yml`:
- Around line 314-338: The docker-compose teardown service forest-shutdown never
runs on test failures because api-compare doesn't reach
service_completed_successfully; update the test orchestration to guarantee
cleanup by either adding the --abort-on-container-exit flag to the docker
compose invocation in setup.sh so compose will shut down all containers when any
exits, or add a process-level fallback trap in api_compare.sh (e.g., trap on
EXIT) that invokes docker compose down to ensure the forest container is
stopped; pick one approach and implement it so forest-shutdown is not relied on
as the sole cleanup path.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 8 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
no green checkmark! ❌ |
@LesnyRumcajs all green now! |
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit