Enable support for Filecoin.EthNewFilter V2#6513
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughEnable Filecoin.EthNewFilter for API v2 routing by changing its API_PATHS from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
I believe this PR will fail the openrpc test enabled by #6523. Let's hold until the other one is merged. |
hanabi1224
left a comment
There was a problem hiding this comment.
Please move the changelog entry to the new unreleased section
Summary of changes
Changes introduced in this pull request:
Filecoin.EthNewFilterV2 asSafeandFinalizedare not yet implemented in lotus.Reference issue to close (if applicable)
Closes #6304
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit