Skip to content

Enable support for Filecoin.EthNewFilter V2#6513

Merged
sudo-shashank merged 14 commits intomainfrom
shashank/enable-eth-new-filter-v2
Feb 10, 2026
Merged

Enable support for Filecoin.EthNewFilter V2#6513
sudo-shashank merged 14 commits intomainfrom
shashank/enable-eth-new-filter-v2

Conversation

@sudo-shashank
Copy link
Contributor

@sudo-shashank sudo-shashank commented Feb 3, 2026

Summary of changes

Changes introduced in this pull request:

  • Enabled support for Filecoin.EthNewFilter V2 as Safe and Finalized are not yet implemented in lotus.

Reference issue to close (if applicable)

Closes #6304

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

Outside contributions

  • I have read and agree to the CONTRIBUTING document.
  • I have read and agree to the AI Policy document. I understand that failure to comply with the guidelines will lead to rejection of the pull request.

Summary by CodeRabbit

  • New Features
    • Filecoin.EthNewFilter is now enabled and reachable via API v2 endpoints. This expands availability to v2 clients while preserving existing parameters, return values, and runtime behavior. No public API signatures or observable method behavior were changed; this update only broadens which endpoints can access the method.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

Walkthrough

Enable Filecoin.EthNewFilter for API v2 routing by changing its API_PATHS from ApiPaths::all() to ApiPaths::all_with_v2() and add a CHANGELOG entry documenting the change.

Changes

Cohort / File(s) Summary
Changelog
CHANGELOG.md
Add entry noting Filecoin.EthNewFilter enabled for API v2 routing.
RPC Method Configuration
src/rpc/methods/eth.rs
Update EthNewFilter const API_PATHS from ApiPaths::all() to ApiPaths::all_with_v2() to include v2 routes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • LesnyRumcajs
  • akaladarshi
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling Filecoin.EthNewFilter support for API v2.
Linked Issues check ✅ Passed The PR successfully implements support for Filecoin.EthNewFilter V2 by updating API_PATHS to include v2, directly addressing the objective from linked issue #6304.
Out of Scope Changes check ✅ Passed All changes are in-scope: CHANGELOG.md entry documents the feature addition and src/rpc/methods/eth.rs enables EthNewFilter for v2 as required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch shashank/enable-eth-new-filter-v2

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sudo-shashank sudo-shashank added RPC requires calibnet RPC checks to run on CI labels Feb 4, 2026
@sudo-shashank sudo-shashank marked this pull request as ready for review February 4, 2026 11:36
@sudo-shashank sudo-shashank requested a review from a team as a code owner February 4, 2026 11:36
@sudo-shashank sudo-shashank requested review from LesnyRumcajs and akaladarshi and removed request for a team February 4, 2026 11:36
@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.38%. Comparing base (99d1f28) to head (cfa28ae).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
src/rpc/methods/eth.rs 69.89% <ø> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99d1f28...cfa28ae. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

hanabi1224
hanabi1224 previously approved these changes Feb 4, 2026
@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 4, 2026
@sudo-shashank sudo-shashank removed this pull request from the merge queue due to a manual request Feb 4, 2026
@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 4, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 4, 2026
@hanabi1224
Copy link
Contributor

I believe this PR will fail the openrpc test enabled by #6523. Let's hold until the other one is merged.

@sudo-shashank sudo-shashank marked this pull request as draft February 6, 2026 05:42
@sudo-shashank sudo-shashank marked this pull request as ready for review February 9, 2026 12:24
Copy link
Contributor

@hanabi1224 hanabi1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the changelog entry to the new unreleased section

@sudo-shashank sudo-shashank added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 2d81b07 Feb 10, 2026
67 of 68 checks passed
@sudo-shashank sudo-shashank deleted the shashank/enable-eth-new-filter-v2 branch February 10, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

RPC requires calibnet RPC checks to run on CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RPC v2] Filecoin.EthNewFilter

2 participants