Add support for the Filecoin.EthGetBlockReceiptsLimited V2#6498
Add support for the Filecoin.EthGetBlockReceiptsLimited V2#6498sudo-shashank merged 5 commits intomainfrom
Conversation
WalkthroughAdds a V2 RPC variant Filecoin.EthGetBlockReceiptsLimited: implements EthGetBlockReceiptsLimitedV2, registers it in the RPC method macro, updates the existing DESCRIPTION, and adds tests and a snapshot entry for the new V2 behavior. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/rpc/methods/eth.rs`:
- Around line 1778-1780: The DESCRIPTION for the method (const DESCRIPTION) is
misleading because it says "optional limit" while the function signature
requires a limit; update the text to accurately reflect the API behavior: either
state that callers must provide a limit and that they can pass a sentinel value
(e.g., LOOKBACK_NO_LIMIT) to disable limiting, or change the function signature
to accept an optional limit (Option<...>) if you intend it to be truly optional;
reference DESCRIPTION and the limit parameter handling (and the
LOOKBACK_NO_LIMIT constant if used) and make the wording precise such as
"provide a limit; pass LOOKBACK_NO_LIMIT to disable limiting" or adjust the
signature to accept Option and update docs accordingly.
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Summary of changes
Changes introduced in this pull request:
Filecoin.EthGetBlockReceiptsLimitedV2 and added test.Reference issue to close (if applicable)
Closes #6296
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit
New Features
Tests
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.