feat: update forest-cli snapshot export to use v2 format by default#6145
feat: update forest-cli snapshot export to use v2 format by default#6145
forest-cli snapshot export to use v2 format by default#6145Conversation
WalkthroughDefault snapshot export format switched from V1 to V2 in the CLI snapshot export command. The user-facing progress message was updated to include an explicit "v{version}" prefix and the destination path. No control-flow, type, or API signature changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/cli/subcommands/snapshot_cmd.rs (1)
42-42: Approve V2 as default snapshot format
- Confirmed V2 is production-ready and now the recommended default (NV27/F3, Lotus defaults).
- Only
scripts/tests/snapshot_parity/docker-compose.ymlrelies on default; both forest-cli and lotus now default to v2, so parity tests pass unchanged.- No other hardcoded V1 defaults detected.
- Optional: update documentation or tests to explicitly reference v2 default.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/cli/subcommands/snapshot_cmd.rs(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: tests-release
- GitHub Check: tests
- GitHub Check: Build forest binaries on Linux AMD64
- GitHub Check: All lint checks
- GitHub Check: cargo-publish-dry-run
- GitHub Check: Build Ubuntu
- GitHub Check: Build MacOS
🔇 Additional comments (1)
src/cli/subcommands/snapshot_cmd.rs (1)
137-137: FilecoinSnapshotVersion can be safely cast to u64.It’s already serialized with
*self as u64and deserialized viafrom_u64, so includingformat as u64in the progress message is correct.
Summary of changes
@ADobrodey please help confirm this change does not break any infra services and scripts. It'd be great to specify
--formateverywhereChanges introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Summary by CodeRabbit
New Features
Chores