Skip to content

Specify module tsc option#5099

Merged
elmattic merged 5 commits intomainfrom
elmattic/fix-ci-check
Dec 19, 2024
Merged

Specify module tsc option#5099
elmattic merged 5 commits intomainfrom
elmattic/fix-ci-check

Conversation

@elmattic
Copy link
Copy Markdown
Contributor

@elmattic elmattic commented Dec 19, 2024

Summary of changes

Changes introduced in this pull request:

  • Set compilerOptions.module to "Node16"

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@elmattic elmattic requested a review from a team as a code owner December 19, 2024 14:25
@elmattic elmattic requested review from ansermino, hanabi1224 and lemmih and removed request for a team and hanabi1224 December 19, 2024 14:25
Copy link
Copy Markdown
Contributor

@ansermino ansermino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing it was caused by this change: #5091

It seems the scope of this docs check is insufficient. Please add /docs path to the workflow, or I can do it in a subsequent PR.

@@ -3,6 +3,7 @@
"extends": "@tsconfig/docusaurus/tsconfig.json",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"extends": "@tsconfig/docusaurus/tsconfig.json",
"extends": "@docusaurus/tsconfig",

You will need to install this: yarn add --dev @docusaurus/tsconfig`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, the lock file looks quite different now. Could that be a problem?

Copy link
Copy Markdown
Contributor

@ansermino ansermino Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is expected, shouldnt be an issue

@ansermino
Copy link
Copy Markdown
Contributor

@elmattic FYI - #5102

@elmattic elmattic added this pull request to the merge queue Dec 19, 2024
Merged via the queue into main with commit 930c419 Dec 19, 2024
@elmattic elmattic deleted the elmattic/fix-ci-check branch December 19, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants